Skip to content

Fix/update newsletter i18n strings#18932

Closed
arnoudhgz wants to merge 5 commits intomagento:2.2-developfrom
arnoudhgz:fix/update-newsletter-i18n-strings
Closed

Fix/update newsletter i18n strings#18932
arnoudhgz wants to merge 5 commits intomagento:2.2-developfrom
arnoudhgz:fix/update-newsletter-i18n-strings

Conversation

@arnoudhgz
Copy link
Contributor

@arnoudhgz arnoudhgz commented Oct 29, 2018

Description (*)

The messages in the Newsletter module were update, but the messages in the translation files have been forgotten.

When using translation tools it is mandatory to have correct strings in the i18n files. This pull request aims to solve this.

Manual testing scenarios (*)

  1. Compare the messages in app/code/Magento/Newsletter/Controller/Manage/Save.php with the i18n file

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Component: Newsletter labels Oct 29, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Oct 29, 2018

Hi @arnoudhgz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@orlangur orlangur self-assigned this Oct 29, 2018
@orlangur
Copy link
Contributor

orlangur commented Oct 29, 2018

@arnoudhgz could you please get rid of useless merge commits? Is this bug present in 2.3-develop?

@arnoudhgz arnoudhgz closed this Oct 31, 2018
This was referenced Oct 31, 2018
Closed
Merged
@arnoudhgz arnoudhgz mentioned this pull request Nov 8, 2018
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@orlangur orlangur

Labels

Component: Newsletter Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arnoudhgz @magento-engcom-team @orlangur